linux-kernel - Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit() in filter_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090408091432.GA10381@elte.hu>
Date:	Wed, 8 Apr 2009 11:14:32 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Tom Zanussi <tzanussi@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>, fweisbec@...il.com
Subject: Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit()
	in filter_check_discard()


* Ingo Molnar <mingo@...e.hu> wrote:

> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > * Tom Zanussi <tzanussi@...il.com> wrote:
> > 
> > > This patch changes filter_check_discard() to make use of the new 
> > > ring_buffer_discard_commit() function and modifies the current 
> > > users to call the old commit function in the non-discard case.  It 
> > > also introduces a version of filter_check_discard() that uses the 
> > > global trace buffer (filter_current_check_discard()) for those 
> > > cases.
> > > 
> > > v2 changes:
> > > 
> > > - fix compile error noticed by Ingo Molnar
> > > 
> > > Signed-off-by: Tom Zanussi <tzanussi@...il.com>
> > 
> > Thanks Tom, i've applied it to tip:tracing/filters and i've started 
> > testing it.
> 
> still has build failures:
> 
> kernel/built-in.o: In function `filter_check_discard':
> trace.c:(.text+0x5b057): undefined reference to `filter_match_preds'

ah, i'll try your other patch as well that separates the event 
infrastructre from the event-tracer.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/