linux-kernel - Re: [PATCH 01/12] DRBD: lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <807b3a220904080315r7277dd68t1abd08b6c5a830dd@mail.gmail.com>
Date:	Wed, 8 Apr 2009 15:45:13 +0530
From:	Nikanth K <nikanth@...il.com>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de,
	Nikanth Karthikesan <knikanth@...e.de>
Subject: Re: [PATCH 01/12] DRBD: lru_cache

On Mon, Mar 23, 2009 at 9:17 PM, Philipp Reisner
<philipp.reisner@...bit.com> wrote:

> +/* this is developers aid only! */
> +#define PARANOIA_ENTRY() BUG_ON(test_and_set_bit(__LC_PARANOIA, &lc->flags))
> +#define PARANOIA_LEAVE() do { clear_bit(__LC_PARANOIA, &lc->flags); smp_mb__after_clear_bit(); } while (0)
> +#define RETURN(x...)     do { PARANOIA_LEAVE(); return x ; } while (0)
> +


The PARANOIA_LEAVE is used for void functions, so RETURN can be
changed to take a simple non-variadic argument. Or empty RETURN()
could be used everywhere instead of mixing PARANOIA_LEAVE() and
RETURN(). Just to make it consistent.

Also this could be made as nop based on some config debug option?

Thanks
Nikanth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/