linux-kernel - [PATCH] Btrfs: setting variable out of order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090415091126.GA13323@kernel.sg>
Date:	Wed, 15 Apr 2009 17:11:26 +0800
From:	Eugene Teo <eugeneteo@...nel.sg>
To:	Yan Zheng <zheng.yan@...cle.com>
Cc:	linux-kernel@...r.kernel.org, eugeneteo@...nel.sg
Subject: [PATCH] Btrfs: setting variable out of order

This doesn't look intentional.

Signed-off-by: Eugene Teo <eugeneteo@...nel.sg>
---
 fs/btrfs/ctree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index e5b2533..6aa2468 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
btrfs_trans_handle *trans,
        for (i = 0; i < nr; i++) {
                if (total_size + data_size[i] + sizeof(struct btrfs_item) >
                    BTRFS_LEAF_DATA_SIZE(root)) {
-                       break;
                        nr = i;
+                       break;
               	}
                total_data += data_size[i];
                total_size += data_size[i] + sizeof(struct btrfs_item);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/