linux-kernel - Re: [PATCH] Btrfs: setting variable out of order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1239800345.31633.1.camel@think.oraclecorp.com>
Date:	Wed, 15 Apr 2009 08:59:05 -0400
From:	Chris Mason <chris.mason@...cle.com>
To:	Eugene Teo <eugeneteo@...nel.sg>
Cc:	Yan Zheng <zheng.yan@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Btrfs: setting variable out of order

On Wed, 2009-04-15 at 17:11 +0800, Eugene Teo wrote:
> This doesn't look intentional.
>
> Signed-off-by: Eugene Teo <eugeneteo@...nel.sg>
> ---
>  fs/btrfs/ctree.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e5b2533..6aa2468 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
> btrfs_trans_handle *trans,
>         for (i = 0; i < nr; i++) {
>                 if (total_size + data_size[i] + sizeof(struct btrfs_item) >
>                     BTRFS_LEAF_DATA_SIZE(root)) {
> -                       break;
>                         nr = i;
> +                       break;
>                	}

Thanks,

This function isn't used anymore, I'll drop it.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/