linux-kernel - Re: [PATCH 3/4] tracing: pass proto and args to DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417070513.GA24860@infradead.org>
Date:	Fri, 17 Apr 2009 03:05:13 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	mathieu.desnoyers@...ymtl.ca, Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
Subject: Re: [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE

On Thu, Apr 16, 2009 at 11:58:56PM -0700, Jeremy Fitzhardinge wrote:
> Christoph Hellwig wrote:
>> On Thu, Apr 16, 2009 at 11:35:38PM -0700, Jeremy Fitzhardinge wrote:
>>   
>>> -DEFINE_TRACE(power_mark);
>>> +DEFINE_TRACE(power_mark,
>>> +	TP_PROTO(struct power_trace *it, unsigned int type, unsigned int state),
>>> +	      TP_ARGS(it, type, state));
>>>     
>>
>> Wrong indentation, the TP_ARGS should have the same level of indentation
>> (one) as the TP_PROTO.  Also true for all others.
>>   
>
> It's just cut+replace+paste from the DECLARE_TRACE() definitions in  
> trace/power.h.  The proper fix is to not duplicate all that stuff in the  
> first place, but I didn't want to introduce a gratuitous re-indent in  
> the process.

When copying it to a new place I don't think that's a good enough
excuse.


Then again I'd really wish we could get Steve's recents bits merged for
various reasons.  The whole DEFINE_TRACE thing only appeared in 2.6.30
and releasing that one kernel with the half-baked inferior version
sounds like a really bad idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/