linux-kernel - Re: [PATCH] driver core:fix driver_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0904171239540.5119@axis700.grange>
Date:	Fri, 17 Apr 2009 12:41:21 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Ming Lei <tom.leiming@...il.com>
cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core:fix driver_match_device

On Fri, 27 Mar 2009, tom.leiming@...il.com wrote:

> From: Ming Lei <tom.leiming@...il.com>
> 
> This patch fixes a bug introduced in commit
> 49b420a13ff95b449947181190b08367348e3e1b.
> 
> If a instance of bus_type doesn't have  .match method,
> all .probe of drivers in the bus should be called, or else
> the .probe have not a chance to be called.
> 
> Signed-off-by: Ming Lei <tom.leiming@...il.com>
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@....de>

It looks like this patch is _still_ not in the mainline - now that we are 
past rc2... Unless the problem has been fixed differently (I haven't 
tested recent kernels), can we __please__ get it upstream?

Thanks
Guennadi

> ---
>  drivers/base/base.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/base.h b/drivers/base/base.h
> index ddc9749..b528145 100644
> --- a/drivers/base/base.h
> +++ b/drivers/base/base.h
> @@ -115,7 +115,7 @@ extern int driver_probe_device(struct device_driver *drv, struct device *dev);
>  static inline int driver_match_device(struct device_driver *drv,
>  				      struct device *dev)
>  {
> -	return drv->bus->match && drv->bus->match(dev, drv);
> +	return drv->bus->match ? drv->bus->match(dev, drv) : 1;
>  }
>  
>  extern void sysdev_shutdown(void);
> -- 
> 1.6.0.GIT
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/