linux-kernel - Re: [PATCH 0/3] AHCI updates: Marvell AHCI PATA works; pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E85C7E.5020200@garzik.org>
Date:	Fri, 17 Apr 2009 06:39:58 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] AHCI updates: Marvell AHCI PATA works; pata_marvell
 fate?

Alan Cox wrote:
>> Marvell PATA on 6121 and similar chips should also work, but that hasn't
>> yet been tested.  Here's the full list of what still needs testing:
>>
>> - master + slave devices
>> - ATAPI
>> - 6121 (6123? others?)
> 
> LBA48

And 80-pin cables...  I cannot find where it permits cable detection or 
where DMA/PIO mode in AHCI mode, complicating things :(

>> Also, there is the open question of how to deal with pata_marvell
>> co-existence
> 
> I think for the moment make PATA support by AHCI a config option and as
> soon as we trust it we can get rid of the option and of pata_marvell.

I'm not sure I see the worth of making PATA, solely, a config option?

Today, the choice is either pata_marvell (PATA) or ahci w/ module option 
(SATA).

My patches morph that choice into: pata_marvell (PATA) or mv-ahci (PATA 
+ SATA).

Thus, considering the hardware, if the user disables PATA support in 
mv-ahci, they still have the problem of two drivers competing for the 
same PCI IDs - no matter that the drivers would each probe different bus 
types (PATA, or SATA).

We could skip SATA_MV_AHCI if PATA_MARVELL is set in .config...  Now 
that mv-ahci solely contains Marvell PCI IDs, that would have the effect 
at compile-time that a module option would have at runtime.

	Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/