linux-kernel - Re: IMA and fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF1283DDC6.0AD2926E-ON8525759B.004938DD-8525759B.004A1887@us.ibm.com>
Date:	Fri, 17 Apr 2009 09:29:19 -0400
From:	Mimi Zohar <zohar@...ibm.com>
To:	hooanon05@...oo.co.jp
Cc:	linux-kernel@...r.kernel.org,
	david safford <safford@...son.ibm.com>
Subject: Re: IMA and fs

hooanon05@...oo.co.jp wrote on 04/16/2009 09:19:45 AM:

> I have found (at least) two issues about IMA.
> 
> 1.
> Calling stack
> - kmem_cache_alloc(iint_cache, GFP_KERNEL)
> - ima_inode_alloc()
> - inode_init_always()
> - xfs_iget_cache_hit()
> - xfs_iget()
> 
> xfs_iget() holds spinlock before xfs_iget_cache_hit(), and
> ima_inode_alloc() cannot use GFP_KERNEL.

This looks similar to the xfs - IMA problem discussed
http://lkml.org/lkml/2009/2/20/327.
 
> 2.
> ima_path_check() seems to be necessary before every opening a file.
> In 2.6.30-rc1, IMA produces lots of messages and stack trace when NFSD
> opens a file. 
> Does nfsd_open() need to to call ima_path_check()?
> 
> 
> J. R. Okajima

Yes, in order for the open/free to be balanced in ima_file_free().

Mimi Zohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/