linux-kernel - Re: [PATCH 5/5] x86: fix x2apic/intr-remap resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417141516.GE23493@elte.hu>
Date:	Fri, 17 Apr 2009 16:15:16 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Weidong Han <weidong.han@...el.com>
Cc:	dwmw2@...radead.org, allen.m.kay@...el.com, fenghua.yu@...el.com,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH 5/5] x86: fix x2apic/intr-remap resume


* Weidong Han <weidong.han@...el.com> wrote:

>  #ifdef CONFIG_INTR_REMAP
> -	if (intr_remapping_enabled)
> -		reenable_intr_remapping(EIM_32BIT_APIC_ID);
> +	if (intr_remapping_enabled) {
> +		if (x2apic)
> +			reenable_intr_remapping(EIM_32BIT_APIC_ID);
> +		else
> +			reenable_intr_remapping(EIM_8BIT_APIC_ID);

ok, we had this sequence before. Might be worthwile to push the 
x2apic condition into reenable_intr_remapping() itself? That would 
simplify the call sites.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/