linux-kernel - Re: [PATCH 0/5] fix bugs of x2apic/intr-remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417143033.GF23493@elte.hu>
Date:	Fri, 17 Apr 2009 16:30:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Weidong Han <weidong.han@...el.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	dwmw2@...radead.org, allen.m.kay@...el.com, fenghua.yu@...el.com,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org
Subject: Re: [PATCH 0/5] fix bugs of x2apic/intr-remap


* Weidong Han <weidong.han@...el.com> wrote:

> interupt remapping was decoupled from x2apic already, but there 
> are still some issues, such as doesn't ack remapped interrupts 
> correctly, and doesn't remap ioapic interrupt when x2apic is not 
> enabled.
> 
> This patchset fixes the ack for remapped interrupts, and alwasys 
> enables interrupt remapping before ioapic setup to guarantee 
> ioapic interrupts are remapped, adjusts the dependency of x2apic 
> and interrupt remapping in lapic_resume. In addition, add option 
> "nointremap" to disable interrupt remapping.
> 
> The patchset can be applied on linux head. Thanks.
> 
> Weidong Han (5):
>   docs: add nox2apic back to kernel-parameters.txt
>   x86,intr-remap: fix ack for interrupt remapping
>   x86, intr-remap: enable interrupt remapping early
>   x86, intr-remap: add option to disable interrupt remapping
>   x86: fix x2apic/intr-remap resume
> 
>  Documentation/kernel-parameters.txt |    5 ++
>  arch/x86/include/asm/apic.h         |   15 +-----
>  arch/x86/kernel/apic/apic.c         |   91 +++++++++++++++++------------------
>  arch/x86/kernel/apic/io_apic.c      |   32 ++----------
>  drivers/pci/intel-iommu.c           |    9 ----
>  drivers/pci/intr_remapping.c        |   39 ++++++++++-----
>  include/linux/dmar.h                |    1 +
>  7 files changed, 84 insertions(+), 108 deletions(-)

Thanks, this series is exactly what the doctor ordered: it fixes 
real problems and still manages to shrink the code!

I've made a few smaller observations to specific patches but none 
seemed like a real showstopper to me so i've applied your series to 
tip:x86/apic (with minor edits to the changelogs) to get this tested 
some more - pending Ack/Nak from David and Jesse for the IOMMU and 
PCI interactions.

Please do the fixlets/cleanups as delta patches against 
tip:x86/apic:

  http://people.redhat.com/mingo/tip.git/README

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/