linux-kernel - Re: [PATCH 3/5] tracing/events: add rcu locking around trace event prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0904171142010.14919@gandalf.stny.rr.com>
Date:	Fri, 17 Apr 2009 11:42:45 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
cc:	Theodore Tso <tytso@....edu>, LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Subject: Re: [PATCH 3/5] tracing/events: add rcu locking around trace event
 prints


On Fri, 17 Apr 2009, Jeremy Fitzhardinge wrote:

> Steven Rostedt wrote:
> > Ted, is this patch still needed?
> > 
> > I'm starting to have second thoughts on this patch because it may require
> > adding: #include <linux/rcupdate.h> in include/trace/ftrace.h. Jeremy has
> > been struggling with include hell with these files.
> > 
> > Hmm, maybe this is not an issue because we undef CREATE_TRACE_POINTS before
> > calling this.
> > 
> > Jeremy,
> > 
> > Do you see a problem if we include linux/rcupdate.h in ftrace.h?
> > Remember, CREATE_TRACE_POINTS is undefined here.
> >   
> Hm, I don't think that matters; I'm seeing the #include problems when
> generating asm-offsets.h, which doesn't have CREATE_TRACE_POINTS set.
> 
> Or are you saying that you only need to include linux/rcupdate.h when
> CREATE_TRACE_POINTS is set?

Well, this part does not get called when CREATE_TRACE_POINTS is not set. 
And when it is called, it undefines it, so that other headers will not 
include this part.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/