linux-kernel - Re: [PATCH 3/5] tracing/events: add rcu locking around trace event prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417161820.GA26479@mit.edu>
Date:	Fri, 17 Apr 2009 12:18:21 -0400
From:	Theodore Tso <tytso@....edu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Subject: Re: [PATCH 3/5] tracing/events: add rcu locking around trace event
	prints

On Fri, Apr 17, 2009 at 10:08:57AM -0400, Steven Rostedt wrote:
> 
> Ted, is this patch still needed?
> 
> I'm starting to have second thoughts on this patch because it may require 
> adding: #include <linux/rcupdate.h> in include/trace/ftrace.h. Jeremy has 
> been struggling with include hell with these files.

Well, I either need that or I need a way of having a TP_PRINTK_PRE()
and TP_PRINTK_POST() so I can drop in the rcu_read_lock() and
rcu_read_unlock() where needed.  Or I need a TP_PRINTK_DELCARE() so I
can declare the temporary buffer, and we can go down that route.

I haven't been following all of the e-mail threads about the include
hell problem; what are the issues, exactly?  What's the problem with
simply including <linux/rcuupdate.h>, and any needed prequisites in
ftrace.h?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/