linux-kernel - Re: [PATCH] x86: fixup numa_node information for AMD CPU northbridge functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417161445.GE8253@elte.hu>
Date:	Fri, 17 Apr 2009 18:14:45 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andreas Herrmann <andreas.herrmann3@....com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, jbarnes@...tuousgeek.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fixup numa_node information for AMD CPU
	northbridge functions


* Andreas Herrmann <andreas.herrmann3@....com> wrote:

> Currently the numa_node attribute for these PCI devices is 0 (it
> corresponds to the numa_node for PCI bus 0). This is not a big issue
> but incorrect.
> 
> This inconsistency can be fixed by reading the node number from CPU
> NB function 0.
> 
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
> ---
>  arch/x86/kernel/quirks.c |   35 +++++++++++++++++++++++++++++++++++
>  1 files changed, 35 insertions(+), 0 deletions(-)

applied, thanks. Note, i added this impact line to the commit:

 [ Impact: fill in dev->numa_node information, to optimize DMA allocations ]

as numa_node does matter to certain DMA allocations such as 
dma_generic_alloc_coherent() - we (try to) allocate node-local 
memory in that case.

pci_dev::numa_node might be used for more such optimizations in the 
future - so it's generally good to have this filled in correctly.

So it's more than just a fix for an inconsistency.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/