| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090419140355.GA16609@helight> Date: Sun, 19 Apr 2009 22:03:55 +0800 From: Zhenwen Xu <helight.xu@...il.com> To: linux-kernel@...r.kernel.org Cc: viro@...iv.linux.org.uk, eparis@...hat.com, linux-audit@...hat.com Subject: [PATCH] this mutex_lock is miss used This mutex_lock and mutex_unlock has no use in such way. It should be like this way: Signed-off-by: Zhenwen Xu <helight.xu@...il.com> --- kernel/audit.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 9442c35..3176ffa 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -485,12 +485,11 @@ int audit_send_list(void *_dest) /* wait for parent to finish and send an ACK */ mutex_lock(&audit_cmd_mutex); - mutex_unlock(&audit_cmd_mutex); - while ((skb = __skb_dequeue(&dest->q)) != NULL) netlink_unicast(audit_sock, skb, pid, 0); kfree(dest); + mutex_unlock(&audit_cmd_mutex); return 0; } -- 1.5.6.5 -- --------------------------------- Zhenwen Xu - Open and Free Home Page: http://zhwen.org My Studio: http://dim4.cn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists