linux-kernel - Re: [PATCH] this mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090419153228.GU26366@ZenIV.linux.org.uk>
Date:	Sun, 19 Apr 2009 16:32:28 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Zhenwen Xu <helight.xu@...il.com>
Cc:	linux-kernel@...r.kernel.org, eparis@...hat.com,
	linux-audit@...hat.com
Subject: Re: [PATCH] this mutex_lock is miss used

On Sun, Apr 19, 2009 at 10:03:55PM +0800, Zhenwen Xu wrote:
> 
> This mutex_lock and mutex_unlock has no use in such way.

Incorrect.  They delay sending response until we are out of audit_receive().

> It should be like this way:

No, it should not.  In particular, it should *NOT* be held while sending
these packets.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/