linux-kernel - Re: [PATCH] drivers: memory_open cleanup - lookup minor device number from devlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49ED12FB.9020207@uol.com.br>
Date:	Mon, 20 Apr 2009 21:27:39 -0300
From:	Adriano dos Santos Fernandes <adrianosf@....com.br>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	mingo@...e.hu, venkatesh.pallipadi@...el.com,
	suresh.b.siddha@...el.com, arjan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: memory_open cleanup - lookup minor device number
 from devlist

Andrew Morton wrote:
> On Mon, 20 Apr 2009 01:05:23 -0300
> Adriano dos Santos Fernandes <adrianosf@....com.br> wrote:
>
>   
>> memory_open ignores devlist and does a switch for each item, duplicating 
>> code
>> and conditional definitions.
>>
>> Clean it adding backing_dev_info to devlist and use it to lookup for the 
>> minor
>> device.
>>     
>
> The patch looks reasonable, however your email client replaced all tabs
> with spaces and I didn't really feel like fixing it all up.
>   
I'm not having success to let Thunderbird make it right. I put the exact 
same patch attached now.

> I wonder what the lock_kernel() calls in memory_open() are doing.
Hmm, not something I can say while submitting my first patch. ;-)


Adriano


View attachment "memory_open.patch" of type "text/x-patch" (3847 bytes)