linux-kernel - Re: [PATCH] drivers: memory_open cleanup - lookup minor device number from devlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090420170155.9ff82860.akpm@linux-foundation.org>
Date:	Mon, 20 Apr 2009 17:01:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Adriano dos Santos Fernandes <adrianosf@....com.br>
Cc:	mingo@...e.hu, venkatesh.pallipadi@...el.com,
	suresh.b.siddha@...el.com, arjan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: memory_open cleanup - lookup minor device
 number from devlist

On Mon, 20 Apr 2009 01:05:23 -0300
Adriano dos Santos Fernandes <adrianosf@....com.br> wrote:

> memory_open ignores devlist and does a switch for each item, duplicating 
> code
> and conditional definitions.
> 
> Clean it adding backing_dev_info to devlist and use it to lookup for the 
> minor
> device.

The patch looks reasonable, however your email client replaced all tabs
with spaces and I didn't really feel like fixing it all up.

I wonder what the lock_kernel() calls in memory_open() are doing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/