linux-kernel - RE: [RFC v2][PATCH 1/1] intel_txt: Intel(R) TXT and tboot kernel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F65016F6CB04E49BFFA15D4F7B798D998812BA7@orsmsx506.amr.corp.intel.com>
Date:	Wed, 22 Apr 2009 13:47:02 -0700
From:	"Cihula, Joseph" <joseph.cihula@...el.com>
To:	Andi Kleen <andi@...stfloor.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"chrisw@...s-sol.org" <chrisw@...s-sol.org>,
	"jmorris@...ei.org" <jmorris@...ei.org>,
	"jbeulich@...ell.com" <jbeulich@...ell.com>,
	"peterm@...hat.com" <peterm@...hat.com>,
	"Wei, Gang" <gang.wei@...el.com>,
	"Wang, Shane" <shane.wang@...el.com>
Subject: RE: [RFC v2][PATCH 1/1] intel_txt: Intel(R) TXT and tboot kernel
 support

> From: Andi Kleen [mailto:andi@...stfloor.org]
> Sent: Wednesday, April 22, 2009 1:40 PM
>
> On Wed, Apr 22, 2009 at 01:31:01PM -0700, Jeremy Fitzhardinge wrote:
> > Andi Kleen wrote:
> > >This means it explodes with paravirt, right? Do you have a check early
> > >for that?
> > >
> >
> > The tboot stuff should only be run on bare hardware; if there's
> > virtualization under the kernel, then TXT should be happening at that level.
>
> Yes I know, but still this should be enforced.

This code will only be executed if the tboot_shared page is found, which should not be the case if the kernel is running paravirtualized.  But I'm planning to change it to just write_cr3() to be more consistent with other cases where we don't try to specifically exclude paravirt hooks.

Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/