linux-kernel - Re: [PATCH] rtc: Make rtc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090424.002900.11623503.anemo@mba.ocn.ne.jp>
Date:	Fri, 24 Apr 2009 00:29:00 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	alessandro.zummo@...ertech.it
Cc:	akpm@...ux-foundation.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, hcegtvedt@...el.com,
	vapier@...too.org, rongkai.zhan@...driver.com,
	balajirrao@...nmoko.org, david-b@...bell.net,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled

On Thu, 23 Apr 2009 17:02:53 +0200, Alessandro Zummo <alessandro.zummo@...ertech.it> wrote:
>  As I said in my last email to Andrew, I think we can call
>  rtc_update_irq with irqs enabled and we don't probably need
>  any IRQF_ to request_irq . 
>  
>  Are you willing to make some tests in that direction with your
>  drivers?

Yes, if we had consensus of the API change.  But since all my drivers
have IRQF_DISABLED and I don't want to drop them, I'm not a good
tester for this ;)

On Thu, 23 Apr 2009 11:07:38 -0400, Mike Frysinger <vapier.adi@...il.com> wrote:
> we just removed the shared bit from the Blackfin rtc driver because it
> didnt really make sense for us.  i need to test something else, so is
> the only change you need is the one posted originally ?  that makes
> more sense to me than forcing everyone to use IRQF_DISABLED.

My original patch should not be merged as is, as David said in other
mail:

On Thu, 9 Apr 2009 16:27:15 -0700, David Brownell <david-b@...bell.net> wrote:
> Any driver doing that right now is by definition buggy; that
> function is clearly defined to need IRQs blocked:
> 
> /**
>  * rtc_update_irq - report RTC periodic, alarm, and/or update irqs
>  * @rtc: the rtc device
>  * @num: how many irqs are being reported (usually one)
>  * @events: mask of RTC_IRQF with one or more of RTC_PF, RTC_AF, RTC_UF
>  * Context: in_interrupt(), irqs blocked
>  */
> 
> If you're going to change the interface, do it right...
> update that kerneldoc and drivers like rtc-ds130[57],
> rtc-ds1374, and rtc-test which do extra work to follow
> the current interface spec.

I agree on this.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/