linux-kernel - Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0904230807q6c40436wa561d7b26db26cef@mail.gmail.com>
Date:	Thu, 23 Apr 2009 11:07:38 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	rtc-linux@...glegroups.com
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, hcegtvedt@...el.com,
	vapier@...too.org, rongkai.zhan@...driver.com,
	balajirrao@...nmoko.org, david-b@...bell.net,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with 
	irqs enabled

On Thu, Apr 23, 2009 at 11:02, Alessandro Zummo wrote:
> On Thu, 23 Apr 2009 23:51:41 +0900 (JST) Atsushi Nemoto wrote:
>> The IRQF_DISABLED fixes would be better regardless of the
>> rtc_update_irq() API change.  And local_irq_disable fixes are not
>> needed (and should be reverted) if the API change was acked, but no
>> harm for short term fix.
>
>  As I said in my last email to Andrew, I think we can call
>  rtc_update_irq with irqs enabled and we don't probably need
>  any IRQF_ to request_irq .
>
>  Are you willing to make some tests in that direction with your
>  drivers?

we just removed the shared bit from the Blackfin rtc driver because it
didnt really make sense for us.  i need to test something else, so is
the only change you need is the one posted originally ?  that makes
more sense to me than forcing everyone to use IRQF_DISABLED.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/