linux-kernel - Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0904230930w7c9ffaa4x5110c59098ff475b@mail.gmail.com>
Date:	Thu, 23 Apr 2009 12:30:58 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	rtc-linux@...glegroups.com
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, hcegtvedt@...el.com,
	vapier@...too.org, rongkai.zhan@...driver.com,
	balajirrao@...nmoko.org, david-b@...bell.net,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with 
	irqs enabled

On Thu, Apr 23, 2009 at 11:37, Alessandro Zummo wrote:
> On Thu, 23 Apr 2009 11:07:38 -0400 Mike Frysinger wrote:
>> we just removed the shared bit from the Blackfin rtc driver because it
>> didnt really make sense for us.  i need to test something else, so is
>> the only change you need is the one posted originally ?  that makes
>> more sense to me than forcing everyone to use IRQF_DISABLED.
>
>  for the blackfin you should just check if
>  you have locking issues in your irq routine

the Blackfin driver calls rtc_update_irq() from its IRQ handler and
the handler is not registered with IRQF_DISABLED.  it makes more sense
to me to fix rtc_update_irq() than require all RTC drivers to register
with IRQF_DISABLED.  especially in my case as the Blackfin driver
itself doesnt need any locks.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/