linux-kernel - Re: [PATCH 2/5 -tip] cifs: umount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090423191516.GV8633@ZenIV.linux.org.uk>
Date:	Thu, 23 Apr 2009 20:15:16 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Alessio Igor Bogani <abogani@...ware.it>
Cc:	Ingo Molnar <mingo@...e.hu>, Jonathan Corbet <corbet@....net>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	LFSDEV <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown

On Thu, Apr 23, 2009 at 09:12:02PM +0200, Alessio Igor Bogani wrote:
>  	struct cifs_sb_info *cifs_sb = CIFS_SB(sb);
>  	struct cifsTconInfo *tcon;
>  
> -	if (cifs_sb == NULL)
> +	lock_kernel();
> +
> +	if (cifs_sb == NULL) {
> +		unlock_kernel();
>  		return;
> +	}

Huh?  Why would a bleeding *local* *variable* care about BKL at all?

>  	tcon = cifs_sb->tcon;
> -	if (tcon == NULL)
> +	if (tcon == NULL) {
> +		unlock_kernel();
>  		return;
> +	}
>  
>  	read_lock(&cifs_tcp_ses_lock);
>  	if (tcon->tc_count == 1)
>  		tcon->tidStatus = CifsExiting;
>  	read_unlock(&cifs_tcp_ses_lock);
>  
> +	unlock_kernel();
> +
>  	/* cancel_brl_requests(tcon); */ /* BB mark all brl mids as exiting */
>  	/* cancel_notify_requests(tcon); */

... and why would the rest of it *not* care?

>  	if (tcon->ses && tcon->ses->server) {
> -- 
> 1.6.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/