linux-kernel - Re: [PATCH v2] Maxim 1586 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090423200232.GD6642@sirena.org.uk>
Date:	Thu, 23 Apr 2009 21:02:33 +0100
From:	Mark Brown <broonie@...ena.org.uk>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	lrg@...mlogic.co.uk, linux-kernel@...r.kernel.org,
	philipp.zabel@...il.com
Subject: Re: [PATCH v2] Maxim 1586 regulator driver

On Thu, Apr 23, 2009 at 08:10:43PM +0200, Robert Jarzmik wrote:

> +/*
> + * max1586.c  --  Voltage and current regulation for the Maxim 1586
> + *
> + * Copyright (C) 2008 Robert Jarzmik

You're living in the past here!

> +/*
> + * V6 voltage
> + * On I2C bus, sending a "x" byte to the max1586 means :
> + *   set V6 to either 0V, 1.8V, 2.5V, 3V depending on (x & 0x3)
> + * As regulator framework doesn't accept voltages to be 0V, we use 1uV.
> + */

Having seen the regulation constraints you're using on your board I'm
thinking even more that it'd be better to implement enable and disable
operations for the driver.  On the other hand, the driver is useful now
and my other comments are all very much nitpicks so from my point of
view:

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> +	dev_dbg(&client->dev, "changing voltage v6 to %dmv\n",
> +		max1586_v6_calc_voltage(selector) / 1000);

mv should be mV.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/