linux-kernel - Re: [PATCH 29/30] microblaze_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090427113030.GA3681@infradead.org>
Date:	Mon, 27 Apr 2009 07:30:30 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Michal Simek <monstr@...str.eu>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, john.williams@...alogix.com,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

On Mon, Apr 27, 2009 at 12:35:51PM +0200, Michal Simek wrote:
> types and I would like to know about more info.
> For example
> If make sense long long	type for st_blocks. IMHO unsigned will be better.
> And I would like to create new stat64 structure where is not a fault for both noMMU/MMU version.
> In noMMU implementation is st_blocks unsigned long. Is it OK? or unsigned long long is better?

You want unsigned long long for it.  Take a look at e.g. the xtensa
stat.h and just reuse that one.  We should probaly create an
asm-generic/stat.h that new architectures can simply use..

Given that microblaze only got merged in the 2.6.30 window I would
suggest fixing up the nommu variant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/