linux-kernel - Re: [PATCH 01/12] mutex: add atomic_dec_and_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090428132742.7da75691.akpm@linux-foundation.org>
Date:	Tue, 28 Apr 2009 13:27:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Eric Paris <eparis@...hat.com>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	hch@...radead.org, alan@...rguk.ukuu.org.uk, sfr@...b.auug.org.au,
	john@...nmccutchan.com, rlove@...ve.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 01/12] mutex: add atomic_dec_and_mutex_lock

On Mon, 27 Apr 2009 17:53:05 -0400
Eric Paris <eparis@...hat.com> wrote:

> Much like the atomic_dec_and_lock() function in which we take and hold a
> spin_lock if we drop the atomic to 0 this function takes and holds the
> mutex if we dec the atomic to 0.

I sucked these patches into -mm, mainly for a bit of compile-time and
runtime testing.

I read through them all on the previous iteration.  IIRC my main
impression was that the code and the data structures were not
sufficiently well commented for that review to have been particularly
effective.  Hopefully things improved there?

It would be good if Al and/or hch and/or others could review this work.
Christoph has indicated that he will be doing this.

You didn't reply to all my review comments from last time, but from a
quick random sample I see that some/most comments have been addressed. 
Hopefully all were at least considered.

It's a little worrisome that my comment against this particular patch
was lost, and the patch was verbatim merged into Ingo's perfcounter
branch.  Did anything else get lost?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/