linux-kernel - Re: [PATCH 12/12] inotify: reimplement inotify using fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1240928881.3484.29.camel@localhost.localdomain>
Date:	Tue, 28 Apr 2009 10:28:01 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	alan@...rguk.ukuu.org.uk, sfr@...b.auug.org.au,
	john@...nmccutchan.com, rlove@...ve.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 12/12] inotify: reimplement inotify using fsnotify

On Tue, 2009-04-28 at 05:59 -0400, Christoph Hellwig wrote:
> Btw, one thing I noticed is that this adds tons of code despite making
> dnotify and inotify use command infrastructure.  Do you already add
> features not actually used by inotify and dnotify?

No new unused features.

inotify.c (933 lines) and some other inotify code can be considered dead
when the next series converts audit and will then be marked for removal,
so that would make the stats look a bit better.

The infrastructure code duplicates everything dnotify did and everything
inotify did.  So now they both have to handle each other's proclivities.
It also means things like dnotify get the benefits of the dentry flag
inotify used.  That plus the finer grained event type checking before
locking should actually make this a performance win.

If you see something that isn't needed let me know.  I think I succeeded
in separating all of the infrastructure stuff that was originally
written for fanotify and some of those vestiges into later unsent
patches, "there's history in them-thar patches."

 MAINTAINERS                          |    4 
 fs/inode.c                           |   10 
 fs/notify/Kconfig                    |   13 
 fs/notify/Makefile                   |    4 
 fs/notify/dnotify/Kconfig            |    1 
 fs/notify/dnotify/dnotify.c          |  470 +++++++++++++++----
 fs/notify/fsnotify.c                 |  196 ++++++++
 fs/notify/fsnotify.h                 |   34 +
 fs/notify/group.c                    |  256 ++++++++++
 fs/notify/inode_mark.c               |  425 +++++++++++++++++
 fs/notify/inotify/Kconfig            |   20 
 fs/notify/inotify/Makefile           |    2 
 fs/notify/inotify/inotify.c          |   20 
 fs/notify/inotify/inotify.h          |   21 
 fs/notify/inotify/inotify_fsnotify.c |  147 ++++++
 fs/notify/inotify/inotify_user.c     |  829 ++++++++++++++++-------------------
 fs/notify/notification.c             |  424 +++++++++++++++++
 include/linux/dcache.h               |    3 
 include/linux/dnotify.h              |   29 -
 include/linux/fs.h                   |   10 
 include/linux/fsnotify.h             |  302 +++++++-----
 include/linux/fsnotify_backend.h     |  404 ++++++++++++++++-
 include/linux/mutex.h                |   23 
 init/Kconfig                         |    3 
 24 files changed, 2915 insertions(+), 735 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/