linux-kernel - Re: [PATCH 04/29] x86/perfcounters: rework pmc_amd_save_disable_all() and pmc_amd_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241004466.8021.266.camel@laptop>
Date:	Wed, 29 Apr 2009 13:27:46 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Robert Richter <robert.richter@....com>,
	Paul Mackerras <paulus@...ba.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/29] x86/perfcounters: rework
 pmc_amd_save_disable_all() and pmc_amd_restore_all()

On Wed, 2009-04-29 at 13:19 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> > > disable-all was arguably a hack i introduced and which spread too 
> > > far. Can you see a conceptual need for it?
> > 
> > power suffers the same issue and simply iterates the things like 
> > amd does now.
> > 
> > The thing is, with a global disable you get slightly better 
> > coupling, so in that respect it might be nice to have.
> 
> ok. With system-wide profiling there's no global disable/enable in 
> the fastpath. Do we have any of them in the per task counter 
> fastpath?

the scheduling bits seem to be littered with
hw_perf_save_disable/restore, other than that I think the overflow
interrupt used it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/