linux-kernel - Re: [PATCH 04/27] asm-generic: add legacy I/O header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090501144420.5a3e9c6e@lxorguk.ukuu.org.uk>
Date:	Fri, 1 May 2009 14:44:20 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	Michal Simek <monstr@...str.eu>, linux-arch@...r.kernel.org,
	Remis Lima Baima <remis.developer@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/27] asm-generic: add legacy I/O header files

> /*
>  * CLOCK_TICK_RATE is traditionally the base frequency using the PC-style
>  * i8253 "PIT" timer. Architecture independent device drivers should not
>  * rely on this value.
>  * Any architecture that either has a real PC-style PIT, or does not have a
>  * fixed timer interval at all and just needs to provide some value here
>  * should just fall back to this default.
>  */

They shouldn't define it - we want those invalid cases to error. Stick
CLOCK_TICK_RATE in the depths of the x86 arch includes and then we can
fix the other cases properly. Either the device has an independant clock
of the same frequency (some watchdogs do this), it relies upon a
motherboard timer in which case the platform can define CLOCK_TICK_RATE
(or a better name for it), or it doesn't have any meaning in which case
we *want* it not to compile.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/