linux-kernel - Re: [PATCH] driver-core: devtmpfs - driver core maintained /dev tmpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090501152133.e3f5038c.akpm@linux-foundation.org>
Date:	Fri, 1 May 2009 15:21:33 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com, jblunck@...e.de
Subject: Re: [PATCH] driver-core: devtmpfs - driver core maintained /dev
 tmpfs

On Fri, 1 May 2009 23:59:32 +0200
Kay Sievers <kay.sievers@...y.org> wrote:

> On Fri, May 1, 2009 at 21:26, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > On Fri, 1 May 2009 13:16:22 +0200
> > Kay Sievers <kay.sievers@...y.org> wrote:
> >
> >> On Fri, May 1, 2009 at 07:29, Andrew Morton <akpm@...ux-foundation.org> wrote:
> >>
> >> > dev->type->nodename() might have failed due to -ENOMEM, in which case
> >> > it seems wrong to assume that it returned NULL for <whatever reason you
> >> > thought it might want to return NULL>.
> >> >
> >> > It's all a bit confused.
> >>
> >> This logic is only for providing a custom name hint. Only a few
> >> devices need that at all. If the allocation fails, the default name
> >> will be used, not the custom name.
> >
> > But that's bad, isn't it? __It means that the kernel will come up with
> > one name if the memory allocation succeeded, and a different name if
> > the allocation failed.
> 
> Yeah, sure, it's bad. But I think we have pretty much lost anyway, if
> we run into oom at this stage.
> 
> What should we do instead? If we, for some reason, can not get a
> possible custom name?

Not much - just sayin'.

Presumably the page allocator will have given a big spew, so the
operator knows what went wrong.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/