linux-kernel - Re: [RFC][PATCH 17/35] sparc: create ptemap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241300562.9131.1.camel@localhost.localdomain>
Date:	Sat, 02 May 2009 14:42:42 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	"Daniel K." <dk@...no>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 17/35] sparc: create ptemap.h

On Sat, 2009-05-02 at 07:02 +0000, Daniel K. wrote:
> Dave Hansen wrote:
> > -/* Certain architectures need to do special things when pte's
> > - * within a page table are directly modified.  Thus, the following
> > - * hook is made available.
> > - */
> 
> This is FUBAR'ed, The comment refers to the BTFIXUPDEF_CALL below, and should not
> be moved to asm/ptemap.h 

Thanks for looking through this.  I've fixed this up in my most recent
version.

> > + * This shortcut works on sun4m (and sun4d) because the nocache area is static,
> > + * and sun4c is guaranteed to have no highmem anyway.
> > + */
> 
> Broken comment.
> 
> > +#define pte_offset_map(d, a)		pte_offset_kernel(d,a)
> > +#define pte_offset_map_nested(d, a)	pte_offset_kernel(d,a)
> > +
> > +#define pte_unmap(pte)		do{}while(0)
> > +#define pte_unmap_nested(pte)	do{}while(0)
> > +
> > +#endif
> > +
> > +#endif /* _SPARC_ASM_PTEMAP_H *//*
> 
> Broken comment.
> 
> I realize this is going away in the end, but all the interim steps should
> compile, to aid bisection.

Yup, absolutely.  This is fixed up now, too.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/