linux-kernel - Re: [RFC][PATCH 13/35] parisc: create ptemap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241300759.9131.4.camel@localhost.localdomain>
Date:	Sat, 02 May 2009 14:45:59 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 13/35] parisc: create ptemap.h

On Sat, 2009-05-02 at 10:29 -0400, Kyle McMartin wrote:
> On Fri, May 01, 2009 at 07:42:21AM -0700, Dave Hansen wrote:
> > +#ifndef _PARISC_ASM_PTEMAP_H
> > +#define _PARISC_ASM_PTEMAP_H
> > +
> > +#define pte_offset_map(pmd, address) pte_offset_kernel(pmd, address)
> > +#define pte_offset_map_nested(pmd, address) pte_offset_kernel(pmd, address)
> > +#define pte_unmap(pte) do { } while (0)
> > +#define pte_unmap_nested(pte) do { } while (0)
> > +
> > +#define pte_unmap(pte)			do { } while (0)
> > +#define pte_unmap_nested(pte)		do { } while (0)
> > +
> > +#endif /* _PARISC_ASM_PTEMAP_H */
> 
> You have duplicate definitiosn of pte_unmap{,_nested}?

Heh.  I actually just copied this verbatim from the existing parisc
header.  It already had a duplicate. :)

Anyway, I've made sure not to copy the dup and added a note in the patch
description so that it is much more clear.  I'll show up in the next
post.  Thanks for the review!

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/