linux-kernel - Re: compat ioctl32 for /dev/snapshot?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090504111243.GH23223@one.firstfloor.org>
Date:	Mon, 4 May 2009 13:12:43 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>, rjw@...k.pl
Subject: Re: compat ioctl32 for /dev/snapshot?

On Mon, May 04, 2009 at 02:55:10PM +0400, Michael Tokarev wrote:
> Andi Kleen wrote:
> >Michael Tokarev <mjt@....msk.ru> writes:
> >
> >>Is there any reason why 32-bit uswsusp &Friends does not work
> >>on 64bits kernel?
> >>
> >>For one, 32bits s2disk produces the following when trying to
> >>suspend:
> >>
> >> ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(400c330d){t:'3';sz:12} 
> >> arg(ff853554) on /dev/snapshot
> >> ioctl32(s2disk:4134): Unknown cmd fd(4) cmd(4004330a){t:'3';sz:4} 
> >> arg(00000805) on /dev/snapshot
> >>
> []
> >It's probably just that nobody has written the code yet. In general all
> >missing compat_ioctls are bugs.
> 
> Oh well.
> 
> Is the following patch ok?  I just pulled all the SNAPSHOT_* stuff from

You should ask Rafael (cc'ed) who maintains that code.
> 
> I can't test it so far, because uswsusp tools are broken in mixed
> 32/64bit case in other places.  But at least it compiles fine and
> does not complain anymore.

It would be good to test before merging.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/