[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200905061145.30698.wolfgang.mues@auerswald.de>
Date: Wed, 6 May 2009 11:45:30 +0200
From: Wolfgang Mües <wolfgang.mues@...rswald.de>
To: Pierre Ossman <pierre@...man.eu>
Cc: "Andrew Morton" <akpm@...ux-foundation.org>,
"Matt Fleming" <matt@...sole-pimps.org>,
"David Brownell" <dbrownell@...rs.sourceforge.net>,
"Mike Frysinger" <vapier.adi@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc_spi: do propper retry managment in the block layer
Pierre,
Am Dienstag, 28. April 2009 schrieb Pierre Ossman:
> You're wrong in that EINVAL should not be sent for any kind of runtime
> hardware errors like that. But I might have missed some instances during
> reviews, so there might be drivers that give that error message for
> things they shouldn't.
I checked the drivers sourcecode and found that most drivers are using EINVAL
for non-recoverable parameter errors.
The only driver which uses EINVAL for errors which might result from
transmission failures is mmc_spi.
So I think it would be OK to use another error code in mmc_spi for these
cases:
* EILSEQ Basic format problem with the received or sent data
* (e.g. CRC check failed, incorrect opcode in response
* or bad end bit)
Would you accept a patch to report another error code in mmc_spi?
regards
i. A. Wolfgang Mües
--
Auerswald GmbH & Co. KG
Hardware Development
Telefon: +49 (0)5306 9219 0
Telefax: +49 (0)5306 9219 94
E-Mail: Wolfgang.Mues@...rswald.de
Web: http://www.auerswald.de
--------------------------------------------------------------
Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRA 13289
p.h.G Auerswald Geschäftsführungsges. mbH
Registriert beim AG Braunschweig HRB 7463
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists