linux-kernel - Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A023670.8080306@cn.fujitsu.com>
Date:	Thu, 07 May 2009 09:16:32 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Jason Baron <jbaron@...hat.com>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	fweisbec@...il.com, rostedt@...dmis.org, zhaolei@...fujitsu.com,
	laijs@...fujitsu.com, Li Zefan <lizf@...fujitsu.com>,
	randy.dunlap@...cle.com
Subject: Re: [PATCH v3] ftrace: add a tracepoint for	__raise_softirq_irqoff()



Jason Baron wrote:
> On Tue, May 05, 2009 at 02:41:32PM +0800, Xiao Guangrong wrote:
>> From: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
>>
>> This patch is modified from Mathieu Desnoyers' patch. The original patch
>> can be found here: 
>> 	http://marc.info/?l=linux-kernel&m=123791201816245&w=2
>> This tracepoint can trace the time stamp when softirq action is raised. 
>>
>> Changelog for v1 -> v2: 
>> 1: Use TRACE_EVENT instead of DEFINE_TRACE
>> 2: Move the tracepoint from raise_softirq_irqoff() to
>>    __raise_softirq_irqoff()
>>
>> Changelog for v2 -> v3: 
>> Move the definition of __raise_softifq_irqoff() to .c file when
>> CONFIG_TRACEPOINTS is enabled, to avoid recursive includes
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
>>
> 
> hi,
> 
> Could you please add 'docbook' style comments above TRACE_EVENTi()? We
> recently added a tracepoint docbook to the -tip and it already contains
> an 'irq' chapter, so you just need to add the comments for the raise
> softirq tracepoint. Please see: 
> 
> http://marc.info/?l=linux-kernel&m=124118471411710&w=2
> 

Hi Jason: 

I will add the comments for this tracepoint. 
thanks! 

> thanks,
> 
> -Jason
> 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/