linux-kernel - Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A0231E6.4090707@cn.fujitsu.com>
Date:	Thu, 07 May 2009 08:57:10 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Li Zefan <lizf@...fujitsu.com>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	fweisbec@...il.com, rostedt@...dmis.org, zhaolei@...fujitsu.com,
	laijs@...fujitsu.com
Subject: Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff()



Li Zefan wrote:
>> +TRACE_EVENT(irq_softirq_raise,
> 
> I think 'softirq_raise' is better.
> 
>> +
>> +	TP_PROTO(unsigned int nr),
>> +
>> +	TP_ARGS(nr),
>> +
>> +	TP_STRUCT__entry(
>> +		__field(	unsigned int,	nr	)
>> +	),
>> +
>> +	TP_fast_assign(
>> +		__entry->nr	= nr;
>> +	),
>> +
>> +	TP_printk("softirq=%d action=%s is raised",
>> +		__entry->nr, softirq_to_name[__entry->nr])
> 
> "softirq=%d action=%s" is sufficient.
> 
> Please see TRACE_EVENT(softirq_entry) and TRACE_EVENT(softirq_exit).
> 

Thanks, I will modify it as your suggestions. ;-)

> 
>> +);
>> +


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/