linux-kernel - Re: [RFC PATCH 00/21 v3] amd64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090507142724.GM481@elte.hu>
Date:	Thu, 7 May 2009 16:27:24 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Borislav Petkov <borislav.petkov@....com>
Cc:	akpm@...ux-foundation.org, greg@...ah.com, norsk5@...oo.com,
	tglx@...utronix.de, hpa@...or.com, mchehab@...hat.com,
	aris@...hat.com, edt@....ca, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 00/21 v3] amd64_edac: EDAC module for AMD64


* Borislav Petkov <borislav.petkov@....com> wrote:

> Hi,
> 
> here's v3 of the EDAC module for AMD k8, Fam10h and Fam11h processors.
> Among the changes from the previous version are a split of the
> driver into several .c files based on functionality, removal of
> StinkyIdentifiers and bunch of cleanups all over the place.
> 
> Thanks again to all the reviewers for their constructive comments, as
> always give it a good stare and flame away :).
> 
> There's also a git repo with the patchset based on Linus' branch from
> yesterday:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/bp/amd64_edac.git
> 
> Changelog:
> 
> - v2:
> Highlights are the addition of two helpers to read/write MSRs on several
> CPUs, denoted by a cpumask and using an array of MSR values per-CPU, as
> hpa suggested. Since IMHO they look generic enough I've added them to
> arch/x86/lib/msr-on-cpu.c (now renamed to msr.c).
> 
> Thanks,
> Boris.
> 
> 
>  arch/x86/include/asm/msr.h          |   21 +
>  arch/x86/lib/Makefile               |    2 +-
>  arch/x86/lib/msr-on-cpu.c           |   97 -
>  arch/x86/lib/msr.c                  |  152 ++
>  drivers/edac/Kconfig                |   26 +
>  drivers/edac/Makefile               |   13 +
>  drivers/edac/amd64_edac.c           | 3759 +++++++++++++++++++++++++++++++++++
>  drivers/edac/amd64_edac.h           |  951 +++++++++
>  drivers/edac/amd64_edac_dbg.c       |  291 +++
>  drivers/edac/amd64_edac_err_types.c |  163 ++
>  drivers/edac/amd64_edac_inj.c       |  203 ++
>  11 files changed, 5580 insertions(+), 98 deletions(-)

Regarding workflow, the arch/x86 bits look good to me now, so you've 
got my Acked-by for that. Most of the EDAC patches are hosted in 
-mm, so we could carry them in the x86 tree separately as well and 
export it to linux-next so that -mm will have it automatically.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/