linux-kernel - Re: [PATCH] Double check memmap is actually valid with a memmap has unexpected holes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090507142143.0619.E1E9C6FF@jp.fujitsu.com>
Date:	Thu, 07 May 2009 14:29:15 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Mel Gorman <mel@....ul.ie>, akpm@...ux-foundation.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	hartleys@...ionengravers.com, mcrapet@...il.com,
	linux@....linux.org.uk, fred99@...olina.rr.com,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	Badari Pulavarty <pbadari@...ibm.com>
Subject: Re: [PATCH] Double check memmap is actually valid with a memmap has unexpected holes

Hi.

> > > +		unsigned long pfn;
> > >  
> > > -		pgdat_resize_lock(pgdat, &flags);
> > 
> > How sure are you about removing the acquisition of this lock?  If anything,
> > it appears that pagetypeinfo_showblockcount_print() should be taking this lock.
> 
> I'm completely unsure about it.
> 
> <adds memory hotplug guys to CC>

zone->zone_start_pfn and zone->spanned_pages may be changed by memory hotplug.
The lock must be acquired before getting their values as Mel-san said.

Thanks.

-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/