linux-kernel - Re: [PATCH 01/14] x86, boot: align the .bss section in the decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090508075354.GA6132@lenovo>
Date:	Fri, 8 May 2009 11:53:54 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, vgoyal@...hat.com, hbabu@...ibm.com,
	kexec@...ts.infradead.org, ying.huang@...el.com, mingo@...e.hu,
	tglx@...utronix.de, ebiederm@...ssion.com, sam@...nborg.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 01/14] x86, boot: align the .bss section in the
	decompressor

[H. Peter Anvin - Thu, May 07, 2009 at 03:26:49PM -0700]
| From: H. Peter Anvin <hpa@...or.com>
| 
| Aligning the .bss section makes it trivially faster, and makes using
| larger transfers for the clear slightly easier.
| 
| [ Impact: trivial performance enhancement, future patch prep ]
| 
| Signed-off-by: H. Peter Anvin <hpa@...or.com>
| ---
|  arch/x86/boot/compressed/vmlinux.lds.S |    1 +
|  1 files changed, 1 insertions(+), 0 deletions(-)
| 
| diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
| index 0d26c92..27c168d 100644
| --- a/arch/x86/boot/compressed/vmlinux.lds.S
| +++ b/arch/x86/boot/compressed/vmlinux.lds.S
| @@ -42,6 +42,7 @@ SECTIONS
|  		*(.data.*)
|  		_edata = . ;
|  	}
| +	. = ALIGN(32);
|  	.bss : {
|  		_bss = . ;
|  		*(.bss)
| -- 
| 1.6.0.6
| 

Hi Peter, should not it be ALIGN(8) rather? I thought
we keep these sections as tight as possible in a sake
of limitation of setup code size. Perhaps I miss something.

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/