linux-kernel - Re: [PATCH] x86 MCE: shut up lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090508093757.GY23223@one.firstfloor.org>
Date:	Fri, 8 May 2009 11:37:57 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Shaohua Li <shaohua.li@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86 MCE: shut up lockdep warning

>  - it works around a lockdep warning
> 
>  - you did not realize the real bug while the warning was plain

Well I'm not sure you understood it either :)  Actually I'm pretty
sure you did not. It would have been good if you had awaited proper
review comments before commiting your patch.

I don't think here's really a real bug because cpu hotunplug is single threaded
anyways (cpu add remove lock) and we don't do multiple discoveries in parallel.

The reason the lock is there is only during bringup with multiple CPUs
doing this in parallel on initial bootup. But we can't race against cpu 
hotunplug there because there's not hotunplug before the system
is up with all configured CPUs.

So I think any way of shutting up lockdep is fine here and your
patch is overkill and disables interrupts unnecessarily. 

>  - plus the patch introduces a fragile (because complex)
>    work_on_cpu() call into the CPU hotplug path, which could have 
>    caused followup regressions.

That's a reasonable point,  but doesn't seem strong enough to
do full irq disabling. A better fix would be to find some other
way to shut off this lockdep warning for this case. Is there
such a way?

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/