linux-kernel - Re: [PATCH 16/18] gdrom: dequeue in-flight request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A04C3B9.6090801@kernel.org>
Date:	Sat, 09 May 2009 08:43:53 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Adrian McMenamin <adrian@...golddream.dyndns.info>
CC:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-ide@...r.kernel.org, rusty@...tcorp.com.au,
	James.Bottomley@...senPartnership.com, mike.miller@...com,
	donari75@...il.com, paul.clements@...eleye.com, tim@...erelk.net,
	Geert.Uytterhoeven@...ycom.com, davem@...emloft.net,
	Laurent@...vier.info, jgarzik@...ox.com, jeremy@...source.com,
	grant.likely@...retlab.ca, sfr@...b.auug.org.au,
	bzolnier@...il.com, petkovbb@...glemail.com,
	sshtylyov@...mvista.com, oakad@...oo.com, drzeus@...eus.cx,
	dwmw2@...radead.org, Markus.Lidel@...dowconnect.com,
	wein@...ibm.com, schwidefsky@...ibm.com, zaitcev@...hat.com,
	fujita.tomonori@....ntt.co.jp, axboe@...nel.dk
Subject: Re: [PATCH 16/18] gdrom: dequeue in-flight request

Adrian McMenamin wrote:
> On Fri, 2009-05-08 at 11:54 +0900, Tejun Heo wrote:
>> gdrom already dequeues and fully completes requests on normal path and
>> the error paths can be easily converted to do so too.  Clean it up and
>> dequeue requests on error paths too.
>>
>> While at it remove superflous blk_fs_request() && !blk_rq_sectors()
>> condition check.
>>
>> [ Impact: dequeue in-flight request, cleanup ]
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Cc: Adrian McMenamin <adrian@...en.demon.co.uk>
>> ---
> 
> Tested-by: Adrian McMenamin <adrian@...en.demon.co.uk>
> Acked-by: Adrian McMenamin <adrian@...en.demon.co.uk>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/