linux-kernel - Re: [PATCH 01/18] ide: dequeue in-flight request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 May 2009 08:56:19 +0200
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-ide@...r.kernel.org, rusty@...tcorp.com.au,
	James.Bottomley@...senPartnership.com, mike.miller@...com,
	donari75@...il.com, paul.clements@...eleye.com, tim@...erelk.net,
	Geert.Uytterhoeven@...ycom.com, davem@...emloft.net,
	Laurent@...vier.info, jgarzik@...ox.com, jeremy@...source.com,
	grant.likely@...retlab.ca, adrian@...en.demon.co.uk,
	sfr@...b.auug.org.au, bzolnier@...il.com, petkovbb@...glemail.com,
	sshtylyov@...mvista.com, oakad@...oo.com, drzeus@...eus.cx,
	dwmw2@...radead.org, Markus.Lidel@...dowconnect.com,
	wein@...ibm.com, schwidefsky@...ibm.com, zaitcev@...hat.com,
	fujita.tomonori@....ntt.co.jp, axboe@...nel.dk
Subject: Re: [PATCH 01/18] ide: dequeue in-flight request

On Fri, May 08, 2009 at 11:53:59AM +0900, Tejun Heo wrote:
> ide generally has single request in flight and tracks it using
> hwif->rq and all state handlers follow the following convention.
> 
> * ide_started is returned if the request is in flight.
> 
> * ide_stopped is returned if the queue needs to be restarted.  The
>   request might or might not have been processed fully or partially.
> 
> * hwif->rq is set to NULL, when an issued request completes.
> 
> So, dequeueing model can be implemented by dequeueing after fetch,
> requeueing if hwif->rq isn't NULL on ide_stopped return and doing
> about the same thing on completion / port unlock paths.  These changes
> can be made in ide-io proper.
> 
> In addition to the above main changes, the following updates are
> necessary.
> 
> * ide-cd shouldn't dequeue a request when issuing REQUEST SENSE for it
>   as the request is already dequeued.
> 
> * ide-atapi uses request queue as stack when issuing REQUEST SENSE to
>   put the REQUEST SENSE in front of the failed request.  This now
>   needs to be done using requeueing.
> 
> [ Impact: dequeue in-flight request ]
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Cc: Borislav Petkov <petkovbb@...glemail.com>
> Cc: Sergei Shtylyov <sshtylyov@...mvista.com>

Acked-by: Borislav Petkov <petkovbb@...il.com>

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/