linux-kernel - Re: [patch 3/4] reiserfs: fixup perms when xattrs are disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A07630E.8000503@suse.com>
Date:	Sun, 10 May 2009 19:28:14 -0400
From:	Jeff Mahoney <jeffm@...e.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Al Viro <viro@....linux.org.uk>, reiserfs-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, stefanr@...6.in-berlin.de
Subject: Re: [patch 3/4] reiserfs: fixup perms when xattrs are disabled

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Al Viro wrote:
> On Sun, May 10, 2009 at 04:05:38PM -0400, Jeff Mahoney wrote:
> 
>> +#ifdef CONFIG_REISERFS_FS_XATTR
>> +	/*
>> +	 * Stat data v1 doesn't support ACLs.
>> +	 */
>> +	if (get_inode_sd_version(inode) != STAT_DATA_V1)
>> +		return generic_permission(inode, mask, reiserfs_check_acl);
>> +	else
>> +#endif
>> +		return generic_permission(inode, mask, NULL);
> 
> Matter of style: this kind of mixing the nesting structures is Not Nice(tm),
> so I'd rather turn that into
> 
> +#ifdef CONFIG_REISERFS_FS_XATTR
> +	/*
> +	 * Stat data v1 doesn't support ACLs.
> +	 */
> +	if (get_inode_sd_version(inode) != STAT_DATA_V1)
> +		return generic_permission(inode, mask, reiserfs_check_acl);
> +#endif
> +
> +	return generic_permission(inode, mask, NULL);

Works for me.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkoHYw4ACgkQLPWxlyuTD7JdrACfdMo7wPBtIGBadVEBKiviD4i9
H4oAoKf1GtugtaiTVZdwwveaTPxBRD/T
=JiZ1
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/