linux-kernel - Re: [PATCH] x86: read apic id if it is not acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090511092655.GC26444@elte.hu>
Date:	Mon, 11 May 2009 11:26:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ed Swierk <eswierk@...stanetworks.com>
Subject: Re: [PATCH] x86: read apic id if it is not acpi_lapic -v2


* Yinghai Lu <yinghai@...nel.org> wrote:

> @@ -1590,21 +1591,32 @@ void __init init_apic_mappings(void)
>  	} else
>  		apic_phys = mp_lapic_addr;
>  
> -	set_fixmap_nocache(FIX_APIC_BASE, apic_phys);
> +	/* lets check if we may to NOP'ify apic operations */
> +	if (!cpu_has_apic) {
> +		pr_info("APIC: disable apic facility\n");
> +		apic_disable();
> +		return;
> +	}
> +
> +	/*
> +	 * acpi lapic path already map that address in
> +	 * acpi_register_lapic_address()
> +	 */
>  	apic_printk(APIC_VERBOSE, "mapped APIC to %08lx (%08lx)\n",
>  				APIC_BASE, apic_phys);
> +	if (acpi_lapic)
> +		return;

why do we return here? We should sanity-check the APIC ID even if we 
come from ACPI.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/