linux-kernel - Re: [PATCH][REPOST] Don't export sched_mc_power_savings on multi-socket single core system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090511123529.GH13954@elte.hu>
Date:	Mon, 11 May 2009 14:35:29 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mahesh Jagannath Salgaonkar <mahesh@...ux.vnet.ibm.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	svaidy@...ux.vnet.ibm.com, Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH][REPOST] Don't export sched_mc_power_savings on
	multi-socket single core system


* Mahesh Jagannath Salgaonkar <mahesh@...ux.vnet.ibm.com> wrote:

> My previous post got lost somewhere in lkml list. Hence reposting 
> this patch again.

no, it did not get lost, i gave you the feedback below more than a 
month ago. FYI, this resubmission has the same corrupted-patch 
problem.

	Ingo

----- Forwarded message from Ingo Molnar <mingo@...e.hu> -----

Date: Wed, 8 Apr 2009 13:42:03 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Mahesh Jagannath Salgaonkar <mahesh@...ux.vnet.ibm.com>
Subject: Re: [PATCH] Don't export sched_mc_power_savings on multi-socket
	single core system
Cc: Linux Kernel <linux-kernel@...r.kernel.org>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	svaidy@...ux.vnet.ibm.com, balbir@...ux.vnet.ibm.com,
	dipankar@...ibm.com, Peter Zijlstra <a.p.zijlstra@...llo.nl>


* Mahesh Jagannath Salgaonkar <mahesh@...ux.vnet.ibm.com> wrote:

> Fix to prevent sched_mc_power_saving from being exported through 
> sysfs for multi-scoket single core system. Max cores should be 
> always greater than one (1). My earlier patch that introduced fix 
> for not exporting 'sched_mc_power_saving' on laptops broke it on 
> multi-socket single core system. This fix addresses issue on both 
> laptop and multi-socket single core system. Below are the Test 
> results:

> +#define mc_capable()   (boot_cpu_data.x86_max_cores > 1) && \
> +                       (cpumask_weight(cpu_core_mask(0)) != nr_cpu_ids)
> #define smt_capable()                  (smp_num_siblings > 1)

patch looks good but is whitespace damaged (all tabs were converted 
to spaces). See Documentation/email-clients.txt about how to set up 
your client.

	Ingo

----- End forwarded message -----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/