linux-kernel - Re: [RFC] Replace the watermark-related union in struct zone with awatermark[] array V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242140739.8109.40078.camel@localhost.localdomain>
Date:	Tue, 12 May 2009 08:05:39 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	David Rientjes <rientjes@...gle.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] Replace the watermark-related union in struct zone with 
 awatermark[] array V2

On Tue, 2009-05-12 at 15:13 +0100, Mel Gorman wrote:
> Changelog since V1
>   o Use N_wmark_pages accessors instead of array accesses
> 
> Patch page-allocator-use-allocation-flags-as-an-index-to-the-zone-watermark
> from -mm added a union to struct zone where the watermarks could be accessed
> with either zone->pages_* or a pages_mark array. The concern was that this
> aliasing caused more confusion that it helped.
> 
> This patch replaces the union with a watermark array that is indexed with
> WMARK_* defines accessed via helpers. All call sites that use zone->pages_*
> are updated to use the helpers for accessing the values and the array
> offsets for setting.
> 
> Signed-off-by: Mel Gorman <mel@....ul.ie>
> --- 
>  Documentation/sysctl/vm.txt |   11 ++++++-----
>  Documentation/vm/balance    |   18 +++++++++---------
>  arch/m32r/mm/discontig.c    |    6 +++---
>  include/linux/mmzone.h      |   20 ++++++++++++++------
>  mm/page_alloc.c             |   41 +++++++++++++++++++++--------------------
>  mm/vmscan.c                 |   39 +++++++++++++++++++++------------------
>  mm/vmstat.c                 |    6 +++---
>  7 files changed, 77 insertions(+), 64 deletions(-)

Looks nice.  It net adds a few lines of code, but that's mostly from the
#defines and not added complexity or lots of line wrapping.  

Ackedf-by: Dave Hansen <dave@...ux.vnet.ibm.com>

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/