linux-kernel - Re: [PATCH urcu] Use pthread_equal() for pthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090512185415.GA22500@Krystal>
Date:	Tue, 12 May 2009 14:54:16 -0400
From:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
To:	Bert Wesarg <bert.wesarg@...glemail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH urcu] Use pthread_equal() for pthread_t's equality test

* Bert Wesarg (bert.wesarg@...glemail.com) wrote:
> Signed-off-by: Bert Wesarg <bert.wesarg@...glemail.com>
> ---
>  urcu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

Hi Bert,

I have to ask all userspace RCU committers for permission to move the
code to LGPL. IBM already gave their approval. Is it OK with you wrt to
the patch you posted here ?

Mathieu

> diff --git a/urcu.c b/urcu.c
> index d0d6138..e401d8d 100644
> --- a/urcu.c
> +++ b/urcu.c
> @@ -185,7 +185,7 @@ void urcu_remove_reader(pthread_t id)
>  
>  	assert(reader_data != NULL);
>  	for (index = reader_data; index < reader_data + num_readers; index++) {
> -		if (index->tid == id) {
> +		if (pthread_equal(index->tid, id)) {
>  			memcpy(index, &reader_data[num_readers - 1],
>  				sizeof(struct reader_data));
>  			reader_data[num_readers - 1].tid = 0;
> -- 
> 1.6.1.rc4
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/