linux-kernel - Re: [PATCH 1/2] usb hcd: poll hcd device to force writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A0AB18D.9070202@windriver.com>
Date:	Wed, 13 May 2009 06:39:57 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	greg@...ah.com, linux-usb@...r.kernel.org, oliver@...kum.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb hcd: poll hcd device to force writes

Alan Stern wrote:
> On Tue, 12 May 2009, Jason Wessel wrote:
>
>   
>> +	if (!urb)
>> +		return;
>>     
>
> Is this test really needed?  
Doesn't look like it.
>
> Maybe you should pass a pointer to a usb_bus structure rather than an
> URB.  Then none of these issues would arise.
>
>   

I changed it to pass in the device instead (see attached)

>> +
>> +	hcd = bus_to_hcd(urb->dev->bus);
>> +	if (hcd)
>> +		usb_hcd_irq(0, hcd);
>>     
>
> This test too looks strange, since it can never fail.  (See the 
> definition of bus_to_hcd to find out why...)
>   

I agree.

Thanks,
Jason.



View attachment "poll_hcd_device.patch" of type "text/x-diff" (6057 bytes)