linux-kernel - Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A0B2E71.1080807@goop.org>
Date:	Wed, 13 May 2009 13:32:49 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	Jeremy Fitzhardinge <jeremy@...p.org>, Ingo Molnar <mingo@...e.hu>,
	the arch/x86 maintainers <x86@...nel.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Joerg Roedel <joerg.roedel@....com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Alex Nixon <alex.nixon@...rix.com>
Subject: Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions

Jesse Barnes wrote:
>> I'd probably go the weak function path if I were to do either of
>> those, but do you think it would be significantly better?
>>     
>
> Well it would avoid the #undef, which is the gross part.  But since
> it's just a boolean, you could also do
>
> #ifndef PCI_SCAN_ALL_FNS
> #define PCI_SCAN_ALL_FNS 0
> #endif
>
> in the generic code, then just set it to 1 before asm-generic/pci.h
> gets included.  That would mean updating arch code though.
>   

If its just x86 then that's OK, but I'd prefer not to have to touch all 
arches.  Hm, doesn't look too bad.

> Anyway it's not a big deal, this code is already ugly (a 0 define for
> all arches?  why?) so you shouldn't have to spend too much time
> cleaning it up.
>   

Yes, it seems to be a vestigial thing which goes into pre-git-history.  
I think when I dug into it, I found there was one Power user of it, but 
that use evaporated in their arch unification.  But I might be 
mis-remembering.

    J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/