linux-kernel - Re: [PATCH] x86: Remove readq()/writeq() on 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A0B4C1C.9000706@garzik.org>
Date:	Wed, 13 May 2009 18:39:24 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	Hitoshi Mitake <h.mitake@...il.com>,
	Roland Dreier <rdreier@...co.com>, Ingo Molnar <mingo@...e.hu>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	tglx@...utronix.de, rpjday@...shcourse.ca,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Remove readq()/writeq() on 32-bit

H. Peter Anvin wrote:
> #include <linux/io64_lh.h>
> 
> linux/io64_lh.h would then look like:
> 
> #ifndef _LINUX_IO64_LH_H
> #define _LINUX_IO64_LH_H
> 
> #include <linux/io.h>
> 
> #ifndef HAVE_READQ
> 
> /* Low-High nonatomic readq() */
> 
> #endif
> 
> #ifndef HAVE_WRITEQ
> 
> /* Low-High nonatomic writeq() */


Judging from this thread and past, I think people will continue to 
complain and get confused, even with the above.

How about

1) tree-wide rename: readq -> readq_na, writeq -> writeq_na

2) make all PCI writel-enabled arches provide readq_na and writeq_na

3) 64-bit PCI writel-enabled arches provide readq and HAVE_READQ, ditto 
for writeq.  32-bit provides neither readq nor HAVE_READQ.

4) If your hardware has non-standard ordering, handle it the obvious way 
in the driver, as you would do with any other special case.

	Jeff



P.S. I use "writel-enabled" to note that some platforms do not provide 
PCI read*/write* functions at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/