linux-kernel - Re: [PATCH] LP3971 PMIC regulator driver (updated and combined version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242730021.5473.2550.camel@vega.slimlogic.co.uk>
Date:	Tue, 19 May 2009 11:47:01 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk, kyungmin.park@...sung.com,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] LP3971 PMIC regulator driver (updated and combined
 version)

On Tue, 2009-05-19 at 10:58 +0100, Mark Brown wrote:
> On Tue, May 19, 2009 at 07:33:55AM +0200, Marek Szyprowski wrote:
> > This patch adds regulator drivers for National Semiconductors LP3971 PMIC.
> > This LP3971 PMIC controller has 3 DC/DC voltage converters and 5 low
> > drop-out
> > (LDO) regulators. LP3971 PMIC controller uses I2C interface.
> 
> > Reviewed-by: Kyungmin Park <kyungmin.park@...sung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> > +static int lp3971_dcdc_list_voltage(struct regulator_dev *dev, unsigned
> > index)
> 
> I'm OK with this but it looks like your MUA has mangled the patch by
> word wrapping so Liam may not be able to apply it.  There's some hints
> on configuring various mail clients in Documentation/email-clients.txt
> which might be helpful.
> 

I've now applied the patch after it was mangled by outlook.

I have also fixed the following build error :-

 CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
`lp3971_i2c_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.devexit.text' of drivers/built-in.o

with this :-

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index 35abebe..a61018a 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -535,7 +535,7 @@ static struct i2c_driver lp3971_i2c_driver = {
                .owner = THIS_MODULE,
        },
        .probe    = lp3971_i2c_probe,
-       .remove   = lp3971_i2c_remove,
+       .remove   = __devexit_p(lp3971_i2c_remove),
        .id_table = lp3971_i2c_id,
 };

Best to pull for-next to get this fix.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/